diff options
| author | Thomas Huth <thuth@redhat.com> | 2022-03-29 08:39:58 +0200 |
|---|---|---|
| committer | Laurent Vivier <laurent@vivier.eu> | 2022-03-31 21:32:49 +0200 |
| commit | 04cca669b237337cc8734788c3ad968aa8e0b57f (patch) | |
| tree | e5d827055fbf03c2256a509a611ed236b8064e35 | |
| parent | ef4ff56cf3335b4d7ad4384c5583439ed5babfa6 (diff) | |
| download | focaccia-qemu-04cca669b237337cc8734788c3ad968aa8e0b57f.tar.gz focaccia-qemu-04cca669b237337cc8734788c3ad968aa8e0b57f.zip | |
tests/lcitool: Do not use a hard-coded /usr/bin/python3 as python interpreter
When running "make lcitool-refresh", this currently uses the hard-coded /usr/bin/python3 from the script's shebang line for running Python. That's bad, since neither /usr/bin/python3 is guaranteed to exist, nor does it honor the python interpreter that the user might have chosen while running the "configure" script. Thus let's rather use $(PYTHON) in the Makefile, and improve the shebang line in the script in case someone runs this directly. Signed-off-by: Thomas Huth <thuth@redhat.com> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Message-Id: <20220329063958.262669-1-thuth@redhat.com> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
| -rw-r--r-- | tests/lcitool/Makefile.include | 2 | ||||
| -rwxr-xr-x | tests/lcitool/refresh | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/tests/lcitool/Makefile.include b/tests/lcitool/Makefile.include index 6b215adcd1..3780185c7c 100644 --- a/tests/lcitool/Makefile.include +++ b/tests/lcitool/Makefile.include @@ -14,4 +14,4 @@ lcitool-help: lcitool lcitool-refresh: $(call quiet-command, cd $(SRC_PATH) && git submodule update --init tests/lcitool/libvirt-ci) - $(call quiet-command, $(LCITOOL_REFRESH)) + $(call quiet-command, $(PYTHON) $(LCITOOL_REFRESH)) diff --git a/tests/lcitool/refresh b/tests/lcitool/refresh index 1f00281b44..2d198ad281 100755 --- a/tests/lcitool/refresh +++ b/tests/lcitool/refresh @@ -1,4 +1,4 @@ -#!/usr/bin/python3 +#!/usr/bin/env python3 # # Re-generate container recipes # |