diff options
| author | Stratos Psomadakis <psomas@grnet.gr> | 2014-01-27 12:30:15 +0200 |
|---|---|---|
| committer | Luiz Capitulino <lcapitulino@redhat.com> | 2014-01-28 12:47:12 -0500 |
| commit | 056f49ff2cf645dc484956b00b65a3aa18a1a9a3 (patch) | |
| tree | f2dc17491a3b8d5be184b3bd396aa9e919a12da9 | |
| parent | 57d3e1b3f52d07d215ed96df946ee01f8d9f9526 (diff) | |
| download | focaccia-qemu-056f49ff2cf645dc484956b00b65a3aa18a1a9a3.tar.gz focaccia-qemu-056f49ff2cf645dc484956b00b65a3aa18a1a9a3.zip | |
monitor: Cleanup mon->outbuf on write error
In case monitor_flush() fails to write the contents of mon->outbuf to the output device, mon->outbuf is not cleaned up properly. Check the return code of the qemu_chr_fe_write() function and cleanup the outbuf if it fails. References: http://lists.nongnu.org/archive/html/qemu-devel/2014-01/msg02890.html Signed-off-by: Stratos Psomadakis <psomas@grnet.gr> Signed-off-by: Dimitris Aragiorgis <dimara@grnet.gr> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
| -rw-r--r-- | monitor.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/monitor.c b/monitor.c index 80456fbe5b..cba56bc4b7 100644 --- a/monitor.c +++ b/monitor.c @@ -288,8 +288,8 @@ void monitor_flush(Monitor *mon) if (len && !mon->mux_out) { rc = qemu_chr_fe_write(mon->chr, (const uint8_t *) buf, len); - if (rc == len) { - /* all flushed */ + if ((rc < 0 && errno != EAGAIN) || (rc == len)) { + /* all flushed or error */ QDECREF(mon->outbuf); mon->outbuf = qstring_new(); return; |