diff options
| author | Markus Armbruster <armbru@redhat.com> | 2023-02-07 08:51:08 +0100 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2023-02-23 14:10:17 +0100 |
| commit | 0ca6745c74778d84c05ca2144cf0d15f8bfe26d8 (patch) | |
| tree | 60663903d320359e3c9193d799802db08607da55 | |
| parent | a0d0267779850f0dee70656dd7c0d11a458bfbaa (diff) | |
| download | focaccia-qemu-0ca6745c74778d84c05ca2144cf0d15f8bfe26d8.tar.gz focaccia-qemu-0ca6745c74778d84c05ca2144cf0d15f8bfe26d8.zip | |
hw/smbios: Dumb down smbios_entry_add() stub
The QERR_ macros are leftovers from the days of "rich" error objects. We've been trying to reduce their remaining use. smbios_entry_add() is only ever called on behalf of CLI option -smbios. Since qemu-options.hx sets @arch_mask to QEMU_ARCH_I386 | QEMU_ARCH_ARM, it is reachable only for these targets. Since they provide a real smbios_entry_add(), the stub is unreachable. There's no point in unreachable code keeping QERR_UNSUPPORTED alive. Dumb it down to g_assert_not_reached(). Signed-off-by: Markus Armbruster <armbru@redhat.com> Message-Id: <20230207075115.1525-6-armbru@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Juan Quintela <quintela@redhat.com>
| -rw-r--r-- | hw/smbios/smbios-stub.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/hw/smbios/smbios-stub.c b/hw/smbios/smbios-stub.c index 64e5ba93ec..e8808adfda 100644 --- a/hw/smbios/smbios-stub.c +++ b/hw/smbios/smbios-stub.c @@ -21,11 +21,9 @@ */ #include "qemu/osdep.h" -#include "qapi/error.h" -#include "qapi/qmp/qerror.h" #include "hw/firmware/smbios.h" void smbios_entry_add(QemuOpts *opts, Error **errp) { - error_setg(errp, QERR_UNSUPPORTED); + g_assert_not_reached(); } |