summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorEduardo Habkost <ehabkost@redhat.com>2014-06-17 17:31:53 -0300
committerAndreas Färber <afaerber@suse.de>2014-06-25 23:54:57 +0200
commit120eee7d1fdb2eba15766cfff7b9bcdc902690b4 (patch)
treef56e55868b7f5ab662e85eb942883365ff203e9d
parent84f1b92f974fbb19967c5f10ac6c3f4a04fb86dd (diff)
downloadfocaccia-qemu-120eee7d1fdb2eba15766cfff7b9bcdc902690b4.tar.gz
focaccia-qemu-120eee7d1fdb2eba15766cfff7b9bcdc902690b4.zip
target-i386: Set migratable=yes by default on "host" CPU mooel
Having only migratable flags reported by default on the "host" CPU model
is safer for the following reasons:

 * Existing users may expect "-cpu host" to be migration-safe, if they
   take care of always using compatible host CPUs, host kernels, and
   QEMU versions.
 * Users who don't care aboug migration and want to enable all features
   supported by the host kernel can simply change their setup to use
   migratable=no.

Without this change, people using "-cpu host" will stop being able to
migrate, because now "invtsc" is getting enabled by default.

We are not setting migratable=yes by default on all X86CPU subclasses,
because users should be able to get non-migratable features enabled if
they ask for them explicitly.

Reviewed-by: Marcelo Tosatti <mtosatti@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
-rw-r--r--target-i386/cpu.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 7d8f9e751e..b651a94e11 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1221,7 +1221,7 @@ static int cpu_x86_fill_model_id(char *str)
 static X86CPUDefinition host_cpudef;
 
 static Property host_x86_cpu_properties[] = {
-    DEFINE_PROP_BOOL("migratable", X86CPU, migratable, false),
+    DEFINE_PROP_BOOL("migratable", X86CPU, migratable, true),
     DEFINE_PROP_END_OF_LIST()
 };