summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorPaolo Bonzini <pbonzini@redhat.com>2015-05-28 16:17:09 +0200
committerStefan Hajnoczi <stefanha@redhat.com>2015-07-02 09:20:18 +0100
commit126b8bbdfe8bc4042f13f230a4b36f90646f47c6 (patch)
treecb528be8dbafad9a26c423f36f6f3639081b14c0
parent4b80ab2b7d950d5b22647b364e37eb81c756f061 (diff)
downloadfocaccia-qemu-126b8bbdfe8bc4042f13f230a4b36f90646f47c6.tar.gz
focaccia-qemu-126b8bbdfe8bc4042f13f230a4b36f90646f47c6.zip
blockdev: no need to drain+flush in hmp_drive_del
bdrv_close already does that, and in fact hmp_drive_del would need
another drain after the flush (which bdrv_close does).  So remove
the duplication.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 1432822629-25401-1-git-send-email-pbonzini@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
-rw-r--r--blockdev.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/blockdev.c b/blockdev.c
index b35467646e..4d5e016e62 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -2167,9 +2167,6 @@ void hmp_drive_del(Monitor *mon, const QDict *qdict)
         return;
     }
 
-    /* quiesce block driver; prevent further io */
-    bdrv_drain_all();
-    bdrv_flush(bs);
     bdrv_close(bs);
 
     /* if we have a device attached to this BlockDriverState