summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorMauro Matteo Cascella <mcascell@redhat.com>2022-12-22 18:29:15 +0100
committerPhilippe Mathieu-Daudé <philmd@linaro.org>2023-02-27 22:29:01 +0100
commit12a51d983de118cf2258fe238b22fabedb4a5ffc (patch)
tree09c725bee922e164ab5e1964b93831b8719d1434
parent38ce1ebf578f3c8cdfb150f397a43d4a65ae74d5 (diff)
downloadfocaccia-qemu-12a51d983de118cf2258fe238b22fabedb4a5ffc.tar.gz
focaccia-qemu-12a51d983de118cf2258fe238b22fabedb4a5ffc.zip
hw/nubus/nubus-device: Fix memory leak in nubus_device_realize
Local variable "name" is allocated through strdup_printf and should be
freed with g_free() to avoid memory leak.

Fixes: 3616f424 ("nubus-device: add romfile property for loading declaration ROMs")
Signed-off-by: Mauro Matteo Cascella <mcascell@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20221222172915.671597-1-mcascell@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
-rw-r--r--hw/nubus/nubus-device.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/hw/nubus/nubus-device.c b/hw/nubus/nubus-device.c
index 0f1852f671..49008e4938 100644
--- a/hw/nubus/nubus-device.c
+++ b/hw/nubus/nubus-device.c
@@ -80,6 +80,7 @@ static void nubus_device_realize(DeviceState *dev, Error **errp)
                                &error_abort);
         ret = load_image_mr(path, &nd->decl_rom);
         g_free(path);
+        g_free(name);
         if (ret < 0) {
             error_setg(errp, "could not load romfile \"%s\"", nd->romfile);
             return;