summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorAvihai Horon <avihaih@nvidia.com>2023-12-31 11:30:13 +0200
committerPeter Xu <peterx@redhat.com>2024-01-04 09:52:42 +0800
commit1d3886f837d8e972366a8b58ba8afb0e5efbeed7 (patch)
tree7ba0267be497de54ef7192de2946daa45373135d
parent6ae208ce9656114e428b1a75ac62a6761ed3216c (diff)
downloadfocaccia-qemu-1d3886f837d8e972366a8b58ba8afb0e5efbeed7.tar.gz
focaccia-qemu-1d3886f837d8e972366a8b58ba8afb0e5efbeed7.zip
migration/multifd: Remove error_setg() in migration_ioc_process_incoming()
If multifd_load_setup() fails in migration_ioc_process_incoming(),
error_setg() is called with errp. This will lead to an assert because in
that case errp already contains an error.

Fix it by removing the redundant error_setg().

Fixes: 6720c2b32725 ("migration: check magic value for deciding the mapping of channels")
Signed-off-by: Avihai Horon <avihaih@nvidia.com>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
Link: https://lore.kernel.org/r/20231231093016.14204-9-avihaih@nvidia.com
Signed-off-by: Peter Xu <peterx@redhat.com>
-rw-r--r--migration/migration.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/migration/migration.c b/migration/migration.c
index 8bb1a8134e..9524c22a50 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -843,7 +843,6 @@ void migration_ioc_process_incoming(QIOChannel *ioc, Error **errp)
     }
 
     if (multifd_load_setup(errp) != 0) {
-        error_setg(errp, "Failed to setup multifd channels");
         return;
     }