diff options
| author | Paolo Bonzini <pbonzini@redhat.com> | 2018-11-29 09:30:59 +0100 |
|---|---|---|
| committer | Paolo Bonzini <pbonzini@redhat.com> | 2019-01-11 13:57:23 +0100 |
| commit | 1ff7ebf33b67b4ec7ea663827e74fe54ac469618 (patch) | |
| tree | 71b6ab1e88cb6382cf37cef79b74b0833822021d | |
| parent | 98e56ae6798cc5f5e432e8d93d5d18ebdeb7e496 (diff) | |
| download | focaccia-qemu-1ff7ebf33b67b4ec7ea663827e74fe54ac469618.tar.gz focaccia-qemu-1ff7ebf33b67b4ec7ea663827e74fe54ac469618.zip | |
checkpatch: fix premature exit when no input or --mailback
In some cases, checkpatch's process subroutine is exiting the whole process. This is wrong, just return from the subroutine instead. Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
| -rwxr-xr-x | scripts/checkpatch.pl | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 18e16b79df..66eb68e85a 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2867,19 +2867,19 @@ sub process { # If we have no input at all, then there is nothing to report on # so just keep quiet. if ($#rawlines == -1) { - exit(0); + return 1; } # In mailback mode only produce a report in the negative, for # things that appear to be patches. if ($mailback && ($clean == 1 || !$is_patch)) { - exit(0); + return 1; } # This is not a patch, and we are are in 'no-patch' mode so # just keep quiet. if (!$chk_patch && !$is_patch) { - exit(0); + return 1; } if (!$is_patch) { |