diff options
| author | Cornelia Huck <cohuck@redhat.com> | 2019-05-02 17:46:51 +0200 |
|---|---|---|
| committer | Cornelia Huck <cohuck@redhat.com> | 2019-05-17 07:57:46 +0200 |
| commit | 216bdd274ae6111102d5f35a4fc6a580e4bc913d (patch) | |
| tree | efb97d7762455ef550a5f63d99d93f72c4566835 | |
| parent | d8276573da58e8ce78dab8c46dd660efd664bcb7 (diff) | |
| download | focaccia-qemu-216bdd274ae6111102d5f35a4fc6a580e4bc913d.tar.gz focaccia-qemu-216bdd274ae6111102d5f35a4fc6a580e4bc913d.zip | |
s390/ipl: cast to SCSIDevice directly
Coverity notes that the result of object_dynamic_cast() to
SCSIDevice is not checked in s390_gen_initial_iplp(); as
we know that we always have a SCSIDevice in that branch,
we can instead cast via SCSI_DEVICE directly.
Coverity: CID 1401098
Fixes: 44445d8668f4 ("s390 vfio-ccw: Add bootindex property and IPLB data")
Message-Id: <20190502155516.12415-1-cohuck@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
| -rw-r--r-- | hw/s390x/ipl.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c index d0cc06a05f..b93750c14e 100644 --- a/hw/s390x/ipl.c +++ b/hw/s390x/ipl.c @@ -374,8 +374,7 @@ static bool s390_gen_initial_iplb(S390IPLState *ipl) if (ccw_dev) { switch (devtype) { case CCW_DEVTYPE_SCSI: - sd = (SCSIDevice *) object_dynamic_cast(OBJECT(dev_st), - TYPE_SCSI_DEVICE); + sd = SCSI_DEVICE(dev_st); ipl->iplb.len = cpu_to_be32(S390_IPLB_MIN_QEMU_SCSI_LEN); ipl->iplb.blk0_len = cpu_to_be32(S390_IPLB_MIN_QEMU_SCSI_LEN - S390_IPLB_HEADER_LEN); |