summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorMarkus Armbruster <armbru@redhat.com>2015-11-24 18:06:28 +0100
committerMarkus Armbruster <armbru@redhat.com>2015-11-25 10:24:15 +0100
commit2825717c02f5b1367e8e315b222888db00618170 (patch)
treee9b1a6df115a25a777f3467e92a20841d3a2869f
parent1613094766602bdb8cae337ceecd8ab68f956197 (diff)
downloadfocaccia-qemu-2825717c02f5b1367e8e315b222888db00618170.tar.gz
focaccia-qemu-2825717c02f5b1367e8e315b222888db00618170.zip
ivshmem: Mark questionable socket type test FIXME
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
-rw-r--r--hw/misc/ivshmem.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index 83d7bd3e5f..edb22704c7 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -939,6 +939,7 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
         memory_region_add_subregion(&s->bar, 0, mr);
         pci_register_bar(PCI_DEVICE(s), 2, attr, &s->bar);
     } else if (s->server_chr != NULL) {
+        /* FIXME do not rely on what chr drivers put into filename */
         if (strncmp(s->server_chr->filename, "unix:", 5)) {
             error_setg(errp, "chardev is not a unix client socket");
             return;