summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorChen Qun <kuhn.chenqun@huawei.com>2020-10-28 13:51:07 +0800
committerDavid Gibson <david@gibson.dropbear.id.au>2020-11-05 12:18:47 +1100
commit295397f53cc1e337e5c1ada62a9ac9feea4d4e97 (patch)
treed57706f9d687bdf4df1de637a5e98a73c95f4550
parent3c8c36c9087da957f580a9bb5ebf7814a753d1c6 (diff)
downloadfocaccia-qemu-295397f53cc1e337e5c1ada62a9ac9feea4d4e97.tar.gz
focaccia-qemu-295397f53cc1e337e5c1ada62a9ac9feea4d4e97.zip
target/ppc/excp_helper: Add a fallthrough for fix compiler warning
When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning:
../target/ppc/excp_helper.c: In function ‘powerpc_excp’:
../target/ppc/excp_helper.c:529:13: warning: this statement may fall through [-Wimplicit-fallthrough=]
  529 |         msr |= env->error_code;
      |         ~~~~^~~~~~~~~~~~~~~~~~
../target/ppc/excp_helper.c:530:5: note: here
  530 |     case POWERPC_EXCP_HDECR:     /* Hypervisor decrementer exception         */
      |     ^~~~

Add the corresponding "fall through" comment to fix it.

Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Message-Id: <20201028055107.2170401-1-kuhn.chenqun@huawei.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
-rw-r--r--target/ppc/excp_helper.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
index d7411bcc81..ad0612555d 100644
--- a/target/ppc/excp_helper.c
+++ b/target/ppc/excp_helper.c
@@ -527,6 +527,7 @@ static inline void powerpc_excp(PowerPCCPU *cpu, int excp_model, int excp)
         break;
     case POWERPC_EXCP_HISI:      /* Hypervisor instruction storage exception */
         msr |= env->error_code;
+        /* fall through */
     case POWERPC_EXCP_HDECR:     /* Hypervisor decrementer exception         */
     case POWERPC_EXCP_HDSI:      /* Hypervisor data storage exception        */
     case POWERPC_EXCP_HDSEG:     /* Hypervisor data segment exception        */