diff options
| author | Alex Williamson <alex.williamson@redhat.com> | 2012-04-05 11:07:21 -0600 |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2012-04-15 12:17:23 +0300 |
| commit | 31745aabcd6dce5583dbd0e5ddee93ff9fdfe3e6 (patch) | |
| tree | 472467df18dbf8ee32965db6fef5af69dab7c914 | |
| parent | 7faa8075d898ae56d2c533c530569bb25ab86eaf (diff) | |
| download | focaccia-qemu-31745aabcd6dce5583dbd0e5ddee93ff9fdfe3e6.tar.gz focaccia-qemu-31745aabcd6dce5583dbd0e5ddee93ff9fdfe3e6.zip | |
acpi_piix4: Remove PCI_RMV_BASE write code
Clarify this register as read-only and remove write code. No change in existing behavior. Signed-off-by: Alex Williamson <alex.williamson@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
| -rw-r--r-- | docs/specs/acpi_pci_hotplug.txt | 2 | ||||
| -rw-r--r-- | hw/acpi_piix4.c | 6 |
2 files changed, 1 insertions, 7 deletions
diff --git a/docs/specs/acpi_pci_hotplug.txt b/docs/specs/acpi_pci_hotplug.txt index 1e2c8a22eb..1883d63061 100644 --- a/docs/specs/acpi_pci_hotplug.txt +++ b/docs/specs/acpi_pci_hotplug.txt @@ -34,4 +34,4 @@ PCI removability status (IO port 0xae0c-0xae0f, 4-byte access): ----------------------------------------------- Used by ACPI BIOS _RMV method to indicate removability status to OS. One -bit per slot. +bit per slot. Read-only diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index 0e7af51063..5d3b0ba11e 100644 --- a/hw/acpi_piix4.c +++ b/hw/acpi_piix4.c @@ -531,11 +531,6 @@ static uint32_t pcirmv_read(void *opaque, uint32_t addr) return s->pci0_hotplug_enable; } -static void pcirmv_write(void *opaque, uint32_t addr, uint32_t val) -{ - return; -} - static int piix4_device_hotplug(DeviceState *qdev, PCIDevice *dev, PCIHotplugState state); @@ -552,7 +547,6 @@ static void piix4_acpi_system_hot_add_init(PCIBus *bus, PIIX4PMState *s) register_ioport_write(PCI_EJ_BASE, 4, 4, pciej_write, s); register_ioport_read(PCI_EJ_BASE, 4, 4, pciej_read, s); - register_ioport_write(PCI_RMV_BASE, 4, 4, pcirmv_write, s); register_ioport_read(PCI_RMV_BASE, 4, 4, pcirmv_read, s); pci_bus_hotplug(bus, piix4_device_hotplug, &s->dev.qdev); |