diff options
| author | Gustavo Romero <gustavo.romero@linaro.org> | 2024-08-13 21:23:12 +0100 |
|---|---|---|
| committer | Alex Bennée <alex.bennee@linaro.org> | 2024-08-16 14:04:19 +0100 |
| commit | 34a4ef1c5cc79bf924938b8cbd5f92146a23a7cb (patch) | |
| tree | 412d89ca2720ff8f3017833ca36427cf2d428122 | |
| parent | 819039a5ad6044467ddad96e656f430198fe1c20 (diff) | |
| download | focaccia-qemu-34a4ef1c5cc79bf924938b8cbd5f92146a23a7cb.tar.gz focaccia-qemu-34a4ef1c5cc79bf924938b8cbd5f92146a23a7cb.zip | |
configure: Avoid use of param. expansion when using gdb_version
$gdb_version is now used in more than one conditional case and its usage in such cases may increase in the future. Therefore, avoid using shell parameter expansion when using it by setting gdb_version to its final form. Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org> Message-Id: <20240804161850.2646299-3-gustavo.romero@linaro.org> Signed-off-by: Alex Bennée <alex.bennee@linaro.org> Message-Id: <20240813202329.1237572-5-alex.bennee@linaro.org>
| -rwxr-xr-x | configure | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/configure b/configure index a3aa257fd3..97de85d710 100755 --- a/configure +++ b/configure @@ -1103,8 +1103,10 @@ fi # gdb test if test -n "$gdb_bin"; then - gdb_version=$($gdb_bin --version | head -n 1) - if version_ge ${gdb_version##* } 9.1; then + gdb_version_string=$($gdb_bin --version | head -n 1) + # Extract last field in the version string + gdb_version=${gdb_version_string##* } + if version_ge $gdb_version 9.1; then gdb_arches=$($python "$source_path/scripts/probe-gdb-support.py" $gdb_bin) else gdb_bin="" @@ -1673,7 +1675,7 @@ for target in $target_list; do echo "GDB=$gdb_bin" >> $config_target_mak fi - if test "${gdb_arches#*aarch64}" != "$gdb_arches" && version_ge ${gdb_version##* } 15.0; then + if test "${gdb_arches#*aarch64}" != "$gdb_arches" && version_ge $gdb_version 15.0; then echo "GDB_HAS_MTE=y" >> $config_target_mak fi |