diff options
| author | Chen Qun <kuhn.chenqun@huawei.com> | 2020-03-11 11:29:27 +0800 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2020-03-27 14:47:23 +0100 |
| commit | 34afc5c298fd4b4279aeec440603b8a1a13ab8c2 (patch) | |
| tree | 39c8cfa3a8e1e735fd44b6a4836147b60ac38420 | |
| parent | cfe68ae025f704f336d7dd3d1903ce37b445831d (diff) | |
| download | focaccia-qemu-34afc5c298fd4b4279aeec440603b8a1a13ab8c2.tar.gz focaccia-qemu-34afc5c298fd4b4279aeec440603b8a1a13ab8c2.zip | |
block/iscsi:use the flags in iscsi_open() prevent Clang warning
Clang static code analyzer show warning:
block/iscsi.c:1920:9: warning: Value stored to 'flags' is never read
flags &= ~BDRV_O_RDWR;
^ ~~~~~~~~~~~~
In iscsi_allocmap_init() only checks BDRV_O_NOCACHE, which
is the same in both of flags and bs->open_flags.
We can use the flags instead bs->open_flags to prevent Clang warning.
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20200311032927.35092-1-kuhn.chenqun@huawei.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
| -rw-r--r-- | block/iscsi.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/block/iscsi.c b/block/iscsi.c index 14680a436a..4e216bd8aa 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -2002,7 +2002,7 @@ static int iscsi_open(BlockDriverState *bs, QDict *options, int flags, iscsilun->cluster_size = iscsilun->bl.opt_unmap_gran * iscsilun->block_size; if (iscsilun->lbprz) { - ret = iscsi_allocmap_init(iscsilun, bs->open_flags); + ret = iscsi_allocmap_init(iscsilun, flags); } } |