diff options
| author | Marc-André Lureau <marcandre.lureau@redhat.com> | 2016-09-12 13:18:56 +0400 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2016-09-19 17:32:21 +0200 |
| commit | 3688d8c717927e7ecaa8c260bc9cc706e3dbef7e (patch) | |
| tree | 5bd9176e8ee634fe950a375de04ef572b41ae423 | |
| parent | e3571ae30cd26d19efd4554c25e32ef64d6a36b3 (diff) | |
| download | focaccia-qemu-3688d8c717927e7ecaa8c260bc9cc706e3dbef7e.tar.gz focaccia-qemu-3688d8c717927e7ecaa8c260bc9cc706e3dbef7e.zip | |
build-sys: define QEMU_VERSION_{MAJOR, MINOR, MICRO}
There are better chances to find what went wrong at build time than a later assert in qmp_query_version Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> Message-Id: <20160912091913.15831-2-marcandre.lureau@redhat.com> Reviewed-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: Markus Armbruster <armbru@redhat.com>
| -rw-r--r-- | qmp.c | 16 | ||||
| -rwxr-xr-x | scripts/create_config | 6 |
2 files changed, 9 insertions, 13 deletions
diff --git a/qmp.c b/qmp.c index dea8f81345..6733463fa2 100644 --- a/qmp.c +++ b/qmp.c @@ -51,21 +51,11 @@ NameInfo *qmp_query_name(Error **errp) VersionInfo *qmp_query_version(Error **errp) { VersionInfo *info = g_new0(VersionInfo, 1); - const char *version = QEMU_VERSION; - const char *tmp; - int err; info->qemu = g_new0(VersionTriple, 1); - err = qemu_strtoll(version, &tmp, 10, &info->qemu->major); - assert(err == 0); - tmp++; - - err = qemu_strtoll(tmp, &tmp, 10, &info->qemu->minor); - assert(err == 0); - tmp++; - - err = qemu_strtoll(tmp, &tmp, 10, &info->qemu->micro); - assert(err == 0); + info->qemu->major = QEMU_VERSION_MAJOR; + info->qemu->minor = QEMU_VERSION_MINOR; + info->qemu->micro = QEMU_VERSION_MICRO; info->package = g_strdup(QEMU_PKGVERSION); return info; diff --git a/scripts/create_config b/scripts/create_config index 1dd6a354f5..e6929dd61e 100755 --- a/scripts/create_config +++ b/scripts/create_config @@ -7,7 +7,13 @@ while read line; do case $line in VERSION=*) # configuration version=${line#*=} + major=$(echo "$version" | cut -d. -f1) + minor=$(echo "$version" | cut -d. -f2) + micro=$(echo "$version" | cut -d. -f3) echo "#define QEMU_VERSION \"$version\"" + echo "#define QEMU_VERSION_MAJOR $major" + echo "#define QEMU_VERSION_MINOR $minor" + echo "#define QEMU_VERSION_MICRO $micro" ;; qemu_*dir=*) # qemu-specific directory configuration name=${line%=*} |