diff options
| author | Philippe Mathieu-Daudé <f4bug@amsat.org> | 2018-06-25 09:42:35 -0300 |
|---|---|---|
| committer | Paolo Bonzini <pbonzini@redhat.com> | 2018-07-02 15:41:17 +0200 |
| commit | 3dc54b0eda03a3400e714f095d17b2f747ed109b (patch) | |
| tree | 4e72a928df284b0dc8efa9a1891b469d806e7321 | |
| parent | 8ec338acfc86cf0360585fb899aca42661616011 (diff) | |
| download | focaccia-qemu-3dc54b0eda03a3400e714f095d17b2f747ed109b.tar.gz focaccia-qemu-3dc54b0eda03a3400e714f095d17b2f747ed109b.zip | |
vl: Use the IEC binary prefix definitions
It eases code review, unit is explicit. Patch generated using: $ git grep -n '[<>][<>]= ?[1-5]0' and modified manually. Suggested-by: Eric Blake <eblake@redhat.com> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Message-Id: <20180625124238.25339-44-f4bug@amsat.org> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
| -rw-r--r-- | vl.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/vl.c b/vl.c index ef6cfcec40..93795c1b9f 100644 --- a/vl.c +++ b/vl.c @@ -23,6 +23,7 @@ */ #include "qemu/osdep.h" +#include "qemu/units.h" #include "qapi/error.h" #include "qemu-version.h" #include "qemu/cutils.h" @@ -2808,8 +2809,8 @@ static void set_memory_options(uint64_t *ram_slots, ram_addr_t *maxram_size, if (g_ascii_isdigit(mem_str[strlen(mem_str) - 1])) { uint64_t overflow_check = sz; - sz <<= 20; - if ((sz >> 20) != overflow_check) { + sz *= MiB; + if (sz / MiB != overflow_check) { error_report("too large 'size' option value"); exit(EXIT_FAILURE); } |