summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorAlexander Bulekov <alxndr@bu.edu>2021-08-04 09:56:20 -0400
committerAlexander Bulekov <alxndr@bu.edu>2021-09-01 07:33:13 -0400
commit40c0d963db2a9d4a49c15554817bbaa11e0bed47 (patch)
tree4bbb0993504f4e51d07ba0974b6e2fef5a1016cc
parentdfc86c0f25126ce3242b317087234c7228418eb2 (diff)
downloadfocaccia-qemu-40c0d963db2a9d4a49c15554817bbaa11e0bed47.tar.gz
focaccia-qemu-40c0d963db2a9d4a49c15554817bbaa11e0bed47.zip
fuzz: use ITIMER_REAL for timeouts
Using ITIMER_VIRTUAL is a bad idea, if the fuzzer hits a blocking
syscall - e.g. ppoll with a NULL timespec. This causes timeout issues
while fuzzing some block-device code. Fix that by using wall-clock time.
This might cause inputs to timeout sometimes due to scheduling
effects/ambient load, but it is better than bringing the entire fuzzing
process to a halt.

Based-on: <20210713150037.9297-1-alxndr@bu.edu>
Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
-rw-r--r--tests/qtest/fuzz/generic_fuzz.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/qtest/fuzz/generic_fuzz.c b/tests/qtest/fuzz/generic_fuzz.c
index 3e8ce29227..de427a3727 100644
--- a/tests/qtest/fuzz/generic_fuzz.c
+++ b/tests/qtest/fuzz/generic_fuzz.c
@@ -695,7 +695,7 @@ static void generic_fuzz(QTestState *s, const unsigned char *Data, size_t Size)
         while (cmd && Size) {
             /* Reset the timeout, each time we run a new command */
             if (timeout) {
-                setitimer(ITIMER_VIRTUAL, &timer, NULL);
+                setitimer(ITIMER_REAL, &timer, NULL);
             }
 
             /* Get the length until the next command or end of input */