diff options
| author | Richard Henderson <richard.henderson@linaro.org> | 2024-08-12 12:58:43 +1000 |
|---|---|---|
| committer | Paolo Bonzini <pbonzini@redhat.com> | 2024-08-13 11:33:34 +0200 |
| commit | 45230bca852f0a8c3a6bd9cb84e621bcde1c7e9a (patch) | |
| tree | 9205c8dc25a4c61e7c58c60e64570901ae63a5c8 | |
| parent | 416f2b16c02c618c0f233372ebfe343f9ee667d4 (diff) | |
| download | focaccia-qemu-45230bca852f0a8c3a6bd9cb84e621bcde1c7e9a.tar.gz focaccia-qemu-45230bca852f0a8c3a6bd9cb84e621bcde1c7e9a.zip | |
target/i386: Use unit not type in decode_modrm
Rather that enumerating the types that can produce MMX operands, examine the unit. No functional change. Signed-off-by: Richard Henderson <richard.henderson@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Link: https://lore.kernel.org/r/20240812025844.58956-3-richard.henderson@linaro.org Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
| -rw-r--r-- | target/i386/tcg/decode-new.c.inc | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/target/i386/tcg/decode-new.c.inc b/target/i386/tcg/decode-new.c.inc index 03138b3876..30be9237c3 100644 --- a/target/i386/tcg/decode-new.c.inc +++ b/target/i386/tcg/decode-new.c.inc @@ -1799,13 +1799,13 @@ static void decode_root(DisasContext *s, CPUX86State *env, X86OpEntry *entry, ui } -static int decode_modrm(DisasContext *s, CPUX86State *env, X86DecodedInsn *decode, - X86DecodedOp *op, X86OpType type) +static int decode_modrm(DisasContext *s, CPUX86State *env, + X86DecodedInsn *decode, X86DecodedOp *op) { int modrm = get_modrm(s, env); if ((modrm >> 6) == 3) { op->n = (modrm & 7); - if (type != X86_TYPE_Q && type != X86_TYPE_N) { + if (op->unit != X86_OP_MMX) { op->n |= REX_B(s); } } else { @@ -2040,7 +2040,7 @@ static bool decode_op(DisasContext *s, CPUX86State *env, X86DecodedInsn *decode, /* fall through */ case X86_TYPE_nop: /* modrm operand decoded but not fetched */ get_modrm: - decode_modrm(s, env, decode, op, type); + decode_modrm(s, env, decode, op); break; case X86_TYPE_O: /* Absolute address encoded in the instruction */ |