summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorMax Reitz <mreitz@redhat.com>2013-10-11 14:30:16 +0200
committerStefan Hajnoczi <stefanha@redhat.com>2013-10-17 14:55:46 +0200
commit45d57f6e718e44e55780bcf1d09fa140dce7ec08 (patch)
treec20e324e778d51aa050280c0960711deb9fdbaf2
parenta7fdbcf0e6e52d935ebff6d849fe4b5473e5860d (diff)
downloadfocaccia-qemu-45d57f6e718e44e55780bcf1d09fa140dce7ec08.tar.gz
focaccia-qemu-45d57f6e718e44e55780bcf1d09fa140dce7ec08.zip
block/raw-win32: Always use -errno in hdev_open
On one occasion, hdev_open() returned -1 in case of an unknown error
instead of a proper -errno value. Adjust this to match the behavior of
raw_open() (in raw-win32), which is to return -EINVAL in this case.
Also, change the call to error_setg*() to match the one in raw_open() as
well.

Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
-rw-r--r--block/raw-win32.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/block/raw-win32.c b/block/raw-win32.c
index c3e4c62d53..676b5701db 100644
--- a/block/raw-win32.c
+++ b/block/raw-win32.c
@@ -590,12 +590,11 @@ static int hdev_open(BlockDriverState *bs, QDict *options, int flags,
         int err = GetLastError();
 
         if (err == ERROR_ACCESS_DENIED) {
-            error_setg_errno(errp, EACCES, "Could not open device");
             ret = -EACCES;
         } else {
-            error_setg(errp, "Could not open device");
-            ret = -1;
+            ret = -EINVAL;
         }
+        error_setg_errno(errp, -ret, "Could not open device");
         goto done;
     }