diff options
| author | Greg Kurz <groug@kaod.org> | 2021-05-07 18:12:28 +0200 |
|---|---|---|
| committer | Laurent Vivier <laurent@vivier.eu> | 2021-05-13 17:48:47 +0200 |
| commit | 4962b312cd2a09902efdf34d91f529164e321b8d (patch) | |
| tree | 74939a1629ff9d0b169a61b1cbff9059c345c2db | |
| parent | 28cbc87be58b490a31f5c2697c79cf0534cd3fea (diff) | |
| download | focaccia-qemu-4962b312cd2a09902efdf34d91f529164e321b8d.tar.gz focaccia-qemu-4962b312cd2a09902efdf34d91f529164e321b8d.zip | |
virtiofsd: Fix check of chown()'s return value
Otherwise you always get this warning when using --socket-group=users
vhost socket failed to set group to users (100)
While here, print out the error if chown() fails.
Fixes: f6698f2b03b0 ("tools/virtiofsd: add support for --socket-group")
Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <162040394890.714971.15502455176528384778.stgit@bahia.lan>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
| -rw-r--r-- | tools/virtiofsd/fuse_virtio.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/virtiofsd/fuse_virtio.c b/tools/virtiofsd/fuse_virtio.c index 1170f375a5..9efdbd8ffd 100644 --- a/tools/virtiofsd/fuse_virtio.c +++ b/tools/virtiofsd/fuse_virtio.c @@ -1024,9 +1024,9 @@ static int fv_create_listen_socket(struct fuse_session *se) if (se->vu_socket_group) { struct group *g = getgrnam(se->vu_socket_group); if (g) { - if (!chown(se->vu_socket_path, -1, g->gr_gid)) { + if (chown(se->vu_socket_path, -1, g->gr_gid) == -1) { fuse_log(FUSE_LOG_WARNING, - "vhost socket failed to set group to %s (%d)\n", + "vhost socket failed to set group to %s (%d): %m\n", se->vu_socket_group, g->gr_gid); } } |