summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorRichard Henderson <richard.henderson@linaro.org>2024-10-04 10:21:59 -0700
committerRichard Henderson <richard.henderson@linaro.org>2024-10-13 11:27:03 -0700
commit49d1866a6e53b84fd0aceced39ee3d01eb77e813 (patch)
tree01aca5e61ea13438eb5ab44a915a3e5f2e746a60
parentd0fb97402278c746ac89059e3dd57d2f59c1cc69 (diff)
downloadfocaccia-qemu-49d1866a6e53b84fd0aceced39ee3d01eb77e813.tar.gz
focaccia-qemu-49d1866a6e53b84fd0aceced39ee3d01eb77e813.zip
accel/tcg: Assert noreturn from write-only page for atomics
There should be no "just in case"; the page is already
in the tlb, and known to be not readable.

Reviewed-by: Helge Deller <deller@gmx.de>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
-rw-r--r--accel/tcg/cputlb.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c
index 117b516739..fd6459b695 100644
--- a/accel/tcg/cputlb.c
+++ b/accel/tcg/cputlb.c
@@ -1852,10 +1852,9 @@ static void *atomic_mmu_lookup(CPUState *cpu, vaddr addr, MemOpIdx oi,
         /*
          * Since we don't support reads and writes to different
          * addresses, and we do have the proper page loaded for
-         * write, this shouldn't ever return.  But just in case,
-         * handle via stop-the-world.
+         * write, this shouldn't ever return.
          */
-        goto stop_the_world;
+        g_assert_not_reached();
     }
     /* Collect tlb flags for read. */
     tlb_addr |= tlbe->addr_read;