diff options
| author | Peter Maydell <peter.maydell@linaro.org> | 2022-08-25 16:07:02 +0100 |
|---|---|---|
| committer | Peter Maydell <peter.maydell@linaro.org> | 2022-09-22 16:38:29 +0100 |
| commit | 563661c05677ad7c4b3f956507f3529df42afbf7 (patch) | |
| tree | 22f19079cc081e6caae456aff7ad41dceab98b2d | |
| parent | cc3c71e89f0b1b18024030976fda650d27806c9f (diff) | |
| download | focaccia-qemu-563661c05677ad7c4b3f956507f3529df42afbf7.tar.gz focaccia-qemu-563661c05677ad7c4b3f956507f3529df42afbf7.zip | |
configure: Check mkdir result directly, not via $?
Shellcheck warns that we have one place where we run a command and then check if it failed using $?; this is better written to simply check the command in the 'if' statement directly. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Message-id: 20220825150703.4074125-7-peter.maydell@linaro.org
| -rwxr-xr-x | configure | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/configure b/configure index 8b48e72a13..b39561b2ed 100755 --- a/configure +++ b/configure @@ -67,8 +67,7 @@ fi # it when configure exits.) TMPDIR1="config-temp" rm -rf "${TMPDIR1}" -mkdir -p "${TMPDIR1}" -if [ $? -ne 0 ]; then +if ! mkdir -p "${TMPDIR1}"; then echo "ERROR: failed to create temporary directory" exit 1 fi |