summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorIan Jackson <ian.jackson@eu.citrix.com>2018-03-08 18:07:26 +0000
committerIan Jackson <Ian.Jackson@eu.citrix.com>2018-04-26 16:29:50 +0100
commit5ac067a24a85fec57d2d87b2d12ae4ffa6aa2d9e (patch)
tree36e419d7229964748cc2ff9dcd999a4dfaea77a3
parentb8846a4d6352b2a1d2012f8b3b9115640524aeda (diff)
downloadfocaccia-qemu-5ac067a24a85fec57d2d87b2d12ae4ffa6aa2d9e.tar.gz
focaccia-qemu-5ac067a24a85fec57d2d87b2d12ae4ffa6aa2d9e.zip
checkpatch: Add xendevicemodel_handle to the list of types
This avoids checkpatch misparsing (as statements) long function
definitions or declarations, which sometimes start with constructs
like this:

  static inline int xendevicemodel_relocate_memory(
      xendevicemodel_handle *dmod, domid_t domid, ...

The type xendevicemodel_handle does not conform to Qemu CODING_STYLE,
which would suggest CamelCase.  However, it is a type defined by the
Xen Project in xen.git.  It would be possible to introduce a typedef
to allow the qemu code to refer to it by a differently-spelled name,
but that would obfuscate more than it would clarify.

CC: Eric Blake <eblake@redhat.com>
CC: Paolo Bonzini <pbonzini@redhat.com>
CC: Daniel P. Berrange <berrange@redhat.com>
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
-rwxr-xr-xscripts/checkpatch.pl1
1 files changed, 1 insertions, 0 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index d52207a3cc..5b8735defb 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -266,6 +266,7 @@ our @typeList = (
 	qr{target_(?:u)?long},
 	qr{hwaddr},
 	qr{xml${Ident}},
+	qr{xendevicemodel_handle},
 );
 
 # This can be modified by sub possible.  Since it can be empty, be careful