diff options
| author | aliguori <aliguori@c046a42c-6fe2-441c-8c8c-71466251a162> | 2009-04-17 20:44:06 +0000 |
|---|---|---|
| committer | aliguori <aliguori@c046a42c-6fe2-441c-8c8c-71466251a162> | 2009-04-17 20:44:06 +0000 |
| commit | 641636d19e3d8eeb8fac31e20641eaf33befd6e7 (patch) | |
| tree | 5c546c61697d72393f4c2286aaf01a326be26d34 | |
| parent | 052ff921416f6d244b93d6c29865ec39517d7aa7 (diff) | |
| download | focaccia-qemu-641636d19e3d8eeb8fac31e20641eaf33befd6e7.tar.gz focaccia-qemu-641636d19e3d8eeb8fac31e20641eaf33befd6e7.zip | |
qcow2 corruption: Fix alloc_cluster_link_l2 (Kevin Wolf)
This patch fixes a qcow2 corruption bug introduced in SVN Rev 5861. L2 tables
are big endian, so entries must be converted before being passed to functions.
This bug is easy to trigger. The following script will create and destroy a
qcow2 image (the header is gone after three loop iterations):
#!/bin/bash
qemu-img create -f qcow2 test.qcow 1M
for i in $(seq 1 10); do
qemu-system-x86_64 -hda test.qcow -monitor stdio > /dev/null 2>&1 <<EOF
savevm test-$i
quit
EOF
done
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@7165 c046a42c-6fe2-441c-8c8c-71466251a162
| -rw-r--r-- | block-qcow2.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/block-qcow2.c b/block-qcow2.c index da8fb42b0c..985214fa07 100644 --- a/block-qcow2.c +++ b/block-qcow2.c @@ -1007,7 +1007,7 @@ static int alloc_cluster_link_l2(BlockDriverState *bs, uint64_t cluster_offset, goto err; for (i = 0; i < j; i++) - free_any_clusters(bs, old_cluster[i], 1); + free_any_clusters(bs, be64_to_cpu(old_cluster[i]), 1); ret = 0; err: |