diff options
| author | Stefan Hajnoczi <stefanha@redhat.com> | 2020-04-16 17:49:07 +0100 |
|---|---|---|
| committer | Dr. David Alan Gilbert <dgilbert@redhat.com> | 2020-05-01 20:05:37 +0100 |
| commit | 66502bbca37ca7a3bfa57e82cfc03b89a7a11eae (patch) | |
| tree | 1b8d5416976ccc3841d3bd4c4170e7a255958c27 | |
| parent | a59feb483b8fae24d043569ccfcc97ea23d54a02 (diff) | |
| download | focaccia-qemu-66502bbca37ca7a3bfa57e82cfc03b89a7a11eae.tar.gz focaccia-qemu-66502bbca37ca7a3bfa57e82cfc03b89a7a11eae.zip | |
virtiofsd: drop all capabilities in the wait parent process
All this process does is wait for its child. No capabilities are needed. Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
| -rw-r--r-- | tools/virtiofsd/passthrough_ll.c | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c index e49650b63d..3ba1d90984 100644 --- a/tools/virtiofsd/passthrough_ll.c +++ b/tools/virtiofsd/passthrough_ll.c @@ -2531,6 +2531,17 @@ static void print_capabilities(void) } /* + * Drop all Linux capabilities because the wait parent process only needs to + * sit in waitpid(2) and terminate. + */ +static void setup_wait_parent_capabilities(void) +{ + capng_setpid(syscall(SYS_gettid)); + capng_clear(CAPNG_SELECT_BOTH); + capng_apply(CAPNG_SELECT_BOTH); +} + +/* * Move to a new mount, net, and pid namespaces to isolate this process. */ static void setup_namespaces(struct lo_data *lo, struct fuse_session *se) @@ -2563,6 +2574,8 @@ static void setup_namespaces(struct lo_data *lo, struct fuse_session *se) pid_t waited; int wstatus; + setup_wait_parent_capabilities(); + /* The parent waits for the child */ do { waited = waitpid(child, &wstatus, 0); |