summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorStefan Berger <stefanb@linux.vnet.ibm.com>2017-11-10 22:33:14 -0500
committerStefan Berger <Stefan Berger stefanb@linux.vnet.ibm.com>2017-11-15 06:47:35 -0500
commit6cd65969da57eaa9bdff07b80ecca2becce0597a (patch)
tree9d685a4ded3ddbe6a634f2adb31b51673f889f35
parentad4aca69bbd40663ca93a3eb1d8042c023b9b407 (diff)
downloadfocaccia-qemu-6cd65969da57eaa9bdff07b80ecca2becce0597a.tar.gz
focaccia-qemu-6cd65969da57eaa9bdff07b80ecca2becce0597a.zip
tpm_tis: Return 0 for every register in case of failure mode
Rather than returning ~0, return 0 for every register in case of failure
mode. The '0' is better to indicate that there's no device there. It avoids
SeaBIOS detecting a device and getting stuck on it trying to read and write
its registers.

Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
-rw-r--r--hw/tpm/tpm_tis.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c
index fec2fc617a..42d647d363 100644
--- a/hw/tpm/tpm_tis.c
+++ b/hw/tpm/tpm_tis.c
@@ -545,7 +545,7 @@ static uint64_t tpm_tis_mmio_read(void *opaque, hwaddr addr,
     uint8_t v;
 
     if (tpm_backend_had_startup_error(s->be_driver)) {
-        return val;
+        return 0;
     }
 
     switch (offset) {