summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorLuiz Capitulino <lcapitulino@redhat.com>2009-07-31 15:15:41 -0300
committerAnthony Liguori <aliguori@us.ibm.com>2009-08-10 13:05:48 -0500
commit73006d2a9a6f226486674c0ee92b5ea5bb1a2cf6 (patch)
treee3b923ca185811c23d0ac0fae8da19b944599c45
parentc3cf0d3f96ed2abdb7b57808244ba39e6a57da8b (diff)
downloadfocaccia-qemu-73006d2a9a6f226486674c0ee92b5ea5bb1a2cf6.tar.gz
focaccia-qemu-73006d2a9a6f226486674c0ee92b5ea5bb1a2cf6.zip
Fix do_commit() behavior
Commit 751c6a17042b5d011013d6963c0505d671cf708e changed the monitor's
'commit' command to this behavior:

1. Any string you type as argument will cause do_commit() to
call bdrv_commit() to all devices

2. If you enter a device name, it will be the only one ignored
by do_commit() :)

The fix is to call bdrv_commit() to the specified device only and
ignore the others (when 'all' is not specified).

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Message-Id: 
-rw-r--r--monitor.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/monitor.c b/monitor.c
index aac88781cc..4b270d98f6 100644
--- a/monitor.c
+++ b/monitor.c
@@ -259,7 +259,7 @@ static void do_commit(Monitor *mon, const char *device)
     all_devices = !strcmp(device, "all");
     TAILQ_FOREACH(dinfo, &drives, next) {
         if (!all_devices)
-            if (!strcmp(bdrv_get_device_name(dinfo->bdrv), device))
+            if (strcmp(bdrv_get_device_name(dinfo->bdrv), device))
                 continue;
         bdrv_commit(dinfo->bdrv);
     }