summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorIgor Mammedov <imammedo@redhat.com>2018-05-16 17:06:14 +0200
committerEduardo Habkost <ehabkost@redhat.com>2018-05-30 13:08:11 -0300
commit74f38e96b321ef8df2bf7fa1bd4f673ef06aca5b (patch)
treed9acebdd53535a85ffddaffc1a771779461d6fd1
parente609fa71e89c81fbe2670411be62da95dfb093e0 (diff)
downloadfocaccia-qemu-74f38e96b321ef8df2bf7fa1bd4f673ef06aca5b.tar.gz
focaccia-qemu-74f38e96b321ef8df2bf7fa1bd4f673ef06aca5b.zip
numa: clarify error message when node index is out of range in -numa dist, ...
When using following CLI:
  -numa dist,src=128,dst=1,val=20
user gets a rather confusing error message:
   "Invalid node 128, max possible could be 128"

Where 128 is number of nodes that QEMU supports (MAX_NODES),
while src/dst is an index up to that limit, so it should be
MAX_NODES - 1 in error message.
Make error message to explicitly state valid range for node
index to be more clear.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Message-Id: <1526483174-169008-1-git-send-email-imammedo@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
-rw-r--r--numa.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/numa.c b/numa.c
index aac22a9612..efc78b2f17 100644
--- a/numa.c
+++ b/numa.c
@@ -141,9 +141,8 @@ static void parse_numa_distance(NumaDistOptions *dist, Error **errp)
     uint8_t val = dist->val;
 
     if (src >= MAX_NODES || dst >= MAX_NODES) {
-        error_setg(errp,
-                   "Invalid node %d, max possible could be %d",
-                   MAX(src, dst), MAX_NODES);
+        error_setg(errp, "Parameter '%s' expects an integer between 0 and %d",
+                   src >= MAX_NODES ? "src" : "dst", MAX_NODES - 1);
         return;
     }