diff options
| author | Thomas Huth <thuth@redhat.com> | 2023-06-27 09:47:01 +0200 |
|---|---|---|
| committer | Thomas Huth <thuth@redhat.com> | 2023-06-29 20:45:12 +0200 |
| commit | 74fe98ee7fb3344dbd085d1fa32c0dc2fc2c831f (patch) | |
| tree | 16b8ecb2d112cc14ad2662179ead77a629bd0d36 | |
| parent | f52420fa4fd9f519dc42c20d2616aba4149adc25 (diff) | |
| download | focaccia-qemu-74fe98ee7fb3344dbd085d1fa32c0dc2fc2c831f.tar.gz focaccia-qemu-74fe98ee7fb3344dbd085d1fa32c0dc2fc2c831f.zip | |
pc-bios/s390-ccw: Provide space for initial stack frame in start.S
Providing the space of a stack frame is the duty of the caller, so we should reserve 160 bytes before jumping into the main function. Otherwise the main() function might write past the stack array. While we're at it, add a proper STACK_SIZE macro for the stack size instead of using magic numbers (this is also required for the following patch). Reviewed-by: Christian Borntraeger <borntraeger@linux.ibm.com> Reviewed-by: Cédric Le Goater <clg@redhat.com> Message-Id: <20230627074703.99608-3-thuth@redhat.com> Reviewed-by: Eric Farman <farman@linux.ibm.com> Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com> Reviewed-by: Marc Hartmayer <mhartmay@linux.ibm.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Signed-off-by: Thomas Huth <thuth@redhat.com>
| -rw-r--r-- | pc-bios/s390-ccw/start.S | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/pc-bios/s390-ccw/start.S b/pc-bios/s390-ccw/start.S index d29de09cc6..abd6fe6639 100644 --- a/pc-bios/s390-ccw/start.S +++ b/pc-bios/s390-ccw/start.S @@ -10,10 +10,13 @@ * directory. */ +#define STACK_SIZE 0x8000 +#define STACK_FRAME_SIZE 160 + .globl _start _start: - larl %r15,stack + 0x8000 /* Set up stack */ + larl %r15,stack + STACK_SIZE - STACK_FRAME_SIZE /* Set up stack */ /* clear bss */ larl %r2,__bss_start |