diff options
| author | Peter Xu <peterx@redhat.com> | 2024-02-22 17:52:59 +0800 |
|---|---|---|
| committer | Peter Xu <peterx@redhat.com> | 2024-02-28 11:31:28 +0800 |
| commit | 770de49c00fa9eb262473f282c92979b47b7fd22 (patch) | |
| tree | a3aa6a2aa196fee8dec9789fc5f685eb76d05741 | |
| parent | 0518b5d8d30d3a4d0ea4f45d61527bcdc43044d2 (diff) | |
| download | focaccia-qemu-770de49c00fa9eb262473f282c92979b47b7fd22.tar.gz focaccia-qemu-770de49c00fa9eb262473f282c92979b47b7fd22.zip | |
migration/multifd: Make multifd_channel_connect() return void
It never fails, drop the retval and also the Error**. Suggested-by: Avihai Horon <avihaih@nvidia.com> Reviewed-by: Fabiano Rosas <farosas@suse.de> Link: https://lore.kernel.org/r/20240222095301.171137-4-peterx@redhat.com Signed-off-by: Peter Xu <peterx@redhat.com>
| -rw-r--r-- | migration/multifd.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/migration/multifd.c b/migration/multifd.c index 1d039a4840..af89e05915 100644 --- a/migration/multifd.c +++ b/migration/multifd.c @@ -943,9 +943,7 @@ static bool multifd_tls_channel_connect(MultiFDSendParams *p, return true; } -static bool multifd_channel_connect(MultiFDSendParams *p, - QIOChannel *ioc, - Error **errp) +static void multifd_channel_connect(MultiFDSendParams *p, QIOChannel *ioc) { qio_channel_set_delay(ioc, false); @@ -956,7 +954,6 @@ static bool multifd_channel_connect(MultiFDSendParams *p, p->thread_created = true; qemu_thread_create(&p->thread, p->name, multifd_send_thread, p, QEMU_THREAD_JOINABLE); - return true; } /* @@ -988,7 +985,8 @@ static void multifd_new_send_channel_async(QIOTask *task, gpointer opaque) return; } } else { - ret = multifd_channel_connect(p, ioc, &local_err); + multifd_channel_connect(p, ioc); + ret = true; } out: |