diff options
| author | Fabiano Rosas <farosas@linux.vnet.ibm.com> | 2018-03-12 19:07:52 -0300 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2018-03-26 12:16:00 +0200 |
| commit | 8140e786f045a074928070640e20914873aeb396 (patch) | |
| tree | 741824e2372d6256de93fcf1c754a1389cc8f3f4 | |
| parent | a7328ba55f4535613a54b4ad65a3eb8b1a47cbb7 (diff) | |
| download | focaccia-qemu-8140e786f045a074928070640e20914873aeb396.tar.gz focaccia-qemu-8140e786f045a074928070640e20914873aeb396.zip | |
block/blkreplay: Remove protocol-related fields
The blkreplay driver is not a protocol so it should implement bdrv_open instead of bdrv_file_open and not provide a protocol_name. Attempts to invoke this driver using protocol syntax (i.e. blkreplay:<filename:options:...>) will now fail gracefully: $ qemu-img info blkreplay:foo qemu-img: Could not open 'blkreplay:foo': Unknown protocol 'blkreplay' Signed-off-by: Fabiano Rosas <farosas@linux.vnet.ibm.com> Reviewed-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru> Reviewed-by: Max Reitz <mreitz@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
| -rwxr-xr-x | block/blkreplay.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/block/blkreplay.c b/block/blkreplay.c index 61e44a1949..fe5a9b4a98 100755 --- a/block/blkreplay.c +++ b/block/blkreplay.c @@ -129,10 +129,9 @@ static int coroutine_fn blkreplay_co_flush(BlockDriverState *bs) static BlockDriver bdrv_blkreplay = { .format_name = "blkreplay", - .protocol_name = "blkreplay", .instance_size = 0, - .bdrv_file_open = blkreplay_open, + .bdrv_open = blkreplay_open, .bdrv_close = blkreplay_close, .bdrv_child_perm = bdrv_filter_default_perms, .bdrv_getlength = blkreplay_getlength, |