diff options
| author | Dr. David Alan Gilbert <dgilbert@redhat.com> | 2017-03-07 18:36:37 +0000 |
|---|---|---|
| committer | Juan Quintela <quintela@redhat.com> | 2017-03-16 09:02:26 +0100 |
| commit | 8679638b0e231f97ad3456c681bf569ca7f7f6d5 (patch) | |
| tree | 1a9e583246d731f3e9d18e82193ab506adfa39fc | |
| parent | 463a4ac23bcf0f0b65c850fa66f5ae6e43edd243 (diff) | |
| download | focaccia-qemu-8679638b0e231f97ad3456c681bf569ca7f7f6d5.tar.gz focaccia-qemu-8679638b0e231f97ad3456c681bf569ca7f7f6d5.zip | |
postcopy: Check for shared memory
Postcopy doesn't support migration of RAM shared with another process yet (we've got a bunch of things to understand). Check for the case and don't allow postcopy to be enabled. Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Reviewed-by: Juan Quintela <quintela@redhat.com> Signed-off-by: Juan Quintela <quintela@redhat.com>
| -rw-r--r-- | migration/postcopy-ram.c | 18 |
1 files changed, 18 insertions, 0 deletions
diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c index effbeb64fb..dc80dbb67f 100644 --- a/migration/postcopy-ram.c +++ b/migration/postcopy-ram.c @@ -95,6 +95,19 @@ static bool ufd_version_check(int ufd) return true; } +/* Callback from postcopy_ram_supported_by_host block iterator. + */ +static int test_range_shared(const char *block_name, void *host_addr, + ram_addr_t offset, ram_addr_t length, void *opaque) +{ + if (qemu_ram_is_shared(qemu_ram_block_by_name(block_name))) { + error_report("Postcopy on shared RAM (%s) is not yet supported", + block_name); + return 1; + } + return 0; +} + /* * Note: This has the side effect of munlock'ing all of RAM, that's * normally fine since if the postcopy succeeds it gets turned back on at the @@ -127,6 +140,11 @@ bool postcopy_ram_supported_by_host(void) goto out; } + /* We don't support postcopy with shared RAM yet */ + if (qemu_ram_foreach_block(test_range_shared, NULL)) { + goto out; + } + /* * userfault and mlock don't go together; we'll put it back later if * it was enabled. |