summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorPeter Lieven <pl@dlhnet.de>2012-11-15 15:42:06 +0100
committerPaolo Bonzini <pbonzini@redhat.com>2012-11-28 12:46:13 +0100
commit8da1e18b0cf46b6c95c88bbad1cc50d6dd1bef4b (patch)
tree1bb55e6f7cb394e09a6325e8fa11d645df2b435f
parent03a36f17d7788e4a1e07b3341b18028aa0206845 (diff)
downloadfocaccia-qemu-8da1e18b0cf46b6c95c88bbad1cc50d6dd1bef4b.tar.gz
focaccia-qemu-8da1e18b0cf46b6c95c88bbad1cc50d6dd1bef4b.zip
iscsi: fix segfault in url parsing
If an invalid URL is specified iscsi_get_error(iscsi) is called
with iscsi == NULL.

Signed-off-by: Peter Lieven <pl@kamp.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
-rw-r--r--block/iscsi.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/block/iscsi.c b/block/iscsi.c
index a6a819d68f..5cd8b49a3f 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -947,8 +947,7 @@ static int iscsi_open(BlockDriverState *bs, const char *filename, int flags)
 
     iscsi_url = iscsi_parse_full_url(iscsi, filename);
     if (iscsi_url == NULL) {
-        error_report("Failed to parse URL : %s %s", filename,
-                     iscsi_get_error(iscsi));
+        error_report("Failed to parse URL : %s", filename);
         ret = -EINVAL;
         goto out;
     }