summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorXiaoyao Li <xiaoyao.li@intel.com>2024-12-19 06:01:19 -0500
committerPaolo Bonzini <pbonzini@redhat.com>2025-01-10 23:34:45 +0100
commit8f78378de70fc79fdc7e1318496bd91ddd22df49 (patch)
tree5280a26a439629012d7b19e87274732651acf1a6
parent00ec7be67c3981b486293aa8e0aef9534f229c5e (diff)
downloadfocaccia-qemu-8f78378de70fc79fdc7e1318496bd91ddd22df49.tar.gz
focaccia-qemu-8f78378de70fc79fdc7e1318496bd91ddd22df49.zip
i386/topology: Update the comment of x86_apicid_from_topo_ids()
Update the comment of x86_apicid_from_topo_ids() to match the current
implementation,

Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
Link: https://lore.kernel.org/r/20241219110125.1266461-5-xiaoyao.li@intel.com
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
-rw-r--r--include/hw/i386/topology.h5
1 files changed, 3 insertions, 2 deletions
diff --git a/include/hw/i386/topology.h b/include/hw/i386/topology.h
index b2c8bf2de1..21b65219a5 100644
--- a/include/hw/i386/topology.h
+++ b/include/hw/i386/topology.h
@@ -121,9 +121,10 @@ static inline unsigned apicid_pkg_offset(X86CPUTopoInfo *topo_info)
 }
 
 /*
- * Make APIC ID for the CPU based on Pkg_ID, Core_ID, SMT_ID
+ * Make APIC ID for the CPU based on topology and IDs of each topology level.
  *
- * The caller must make sure core_id < nr_cores and smt_id < nr_threads.
+ * The caller must make sure the ID of each level doesn't exceed the width of
+ * the level.
  */
 static inline apic_id_t x86_apicid_from_topo_ids(X86CPUTopoInfo *topo_info,
                                                  const X86CPUTopoIDs *topo_ids)