diff options
| author | Max Reitz <mreitz@redhat.com> | 2014-02-15 18:03:21 +0100 |
|---|---|---|
| committer | Stefan Hajnoczi <stefanha@redhat.com> | 2014-03-13 14:42:24 +0100 |
| commit | 9562f69cfdc55c7c1625bb88df1637fed182e68b (patch) | |
| tree | 5af0bbb0794565aff9176e23f8e072a5946c5fcc | |
| parent | 27eb6c097c132bf9fc49d73554b0160293b630cd (diff) | |
| download | focaccia-qemu-9562f69cfdc55c7c1625bb88df1637fed182e68b.tar.gz focaccia-qemu-9562f69cfdc55c7c1625bb88df1637fed182e68b.zip | |
block: Unlink temporary file
If the image file cannot be opened and was created as a temporary file, it should be deleted; thus, in this case, we should jump to the "unlink_and_fail" label and not just to "fail". Reported-by: Benoît Canet <benoit@irqsave.net> Signed-off-by: Max Reitz <mreitz@redhat.com> Acked-by: Stefan Hajnoczi <stefanha@redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
| -rw-r--r-- | block.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/block.c b/block.c index cf5645a14a..fae50c95b5 100644 --- a/block.c +++ b/block.c @@ -1321,7 +1321,7 @@ int bdrv_open(BlockDriverState **pbs, const char *filename, bdrv_open_flags(bs, flags | BDRV_O_UNMAP) | BDRV_O_PROTOCOL, true, &local_err); if (ret < 0) { - goto fail; + goto unlink_and_fail; } /* Find the right image format driver */ |