summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorzhenwei pi <pizhenwei@bytedance.com>2023-05-03 19:54:37 +0800
committerMichael S. Tsirkin <mst@redhat.com>2023-06-23 03:09:45 -0400
commita1f85cff902f3260d85c74ec11d4c4b182cead80 (patch)
treee3f10f62f08d5e9c286925a0771a5b4cc75f19f5
parent152128d646973ed298d41dafd7a5bccff43336c8 (diff)
downloadfocaccia-qemu-a1f85cff902f3260d85c74ec11d4c4b182cead80.tar.gz
focaccia-qemu-a1f85cff902f3260d85c74ec11d4c4b182cead80.zip
cryptodev: fix memory leak during stats query
object_get_canonical_path already returns newly allocated memory, this
means no additional g_strdup required. Remove g_strdup to avoid memory
leak.

Fixes: Coverity CID 1508074
Fixes: f2b901098 ("cryptodev: Support query-stats QMP command")
Cc: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
Message-Id: <20230503115437.262469-1-pizhenwei@bytedance.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
-rw-r--r--backends/cryptodev.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/backends/cryptodev.c b/backends/cryptodev.c
index 94ca393cee..7d29517843 100644
--- a/backends/cryptodev.c
+++ b/backends/cryptodev.c
@@ -522,7 +522,7 @@ static int cryptodev_backend_stats_query(Object *obj, void *data)
 
     entry = g_new0(StatsResult, 1);
     entry->provider = STATS_PROVIDER_CRYPTODEV;
-    entry->qom_path = g_strdup(object_get_canonical_path(obj));
+    entry->qom_path = object_get_canonical_path(obj);
     entry->stats = stats_list;
     QAPI_LIST_PREPEND(*stats_results, entry);