summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorIgor Mammedov <imammedo@redhat.com>2013-04-23 10:29:42 +0200
committerAndreas Färber <afaerber@suse.de>2013-05-01 13:04:18 +0200
commita37677c32bb313f5ba48aaf89f81cdc10c23ce56 (patch)
treef5f2a33d4110668bc1d984a227a8401c403c936b
parentd6b9e0d60cc511eca210834428bb74508cff3d33 (diff)
downloadfocaccia-qemu-a37677c32bb313f5ba48aaf89f81cdc10c23ce56.tar.gz
focaccia-qemu-a37677c32bb313f5ba48aaf89f81cdc10c23ce56.zip
cpus: Use qemu_for_each_cpu() in TCG thread
Replaces an open-coded loop and hides unused CPUArchState.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
-rw-r--r--cpus.c13
1 files changed, 7 insertions, 6 deletions
diff --git a/cpus.c b/cpus.c
index 1d8876157c..a2d92c7a88 100644
--- a/cpus.c
+++ b/cpus.c
@@ -812,6 +812,12 @@ static void *qemu_dummy_cpu_thread_fn(void *arg)
 
 static void tcg_exec_all(void);
 
+static void tcg_signal_cpu_creation(CPUState *cpu, void *data)
+{
+    cpu->thread_id = qemu_get_thread_id();
+    cpu->created = true;
+}
+
 static void *qemu_tcg_cpu_thread_fn(void *arg)
 {
     CPUState *cpu = arg;
@@ -820,13 +826,8 @@ static void *qemu_tcg_cpu_thread_fn(void *arg)
     qemu_tcg_init_cpu_signals();
     qemu_thread_get_self(cpu->thread);
 
-    /* signal CPU creation */
     qemu_mutex_lock(&qemu_global_mutex);
-    for (env = first_cpu; env != NULL; env = env->next_cpu) {
-        cpu = ENV_GET_CPU(env);
-        cpu->thread_id = qemu_get_thread_id();
-        cpu->created = true;
-    }
+    qemu_for_each_cpu(tcg_signal_cpu_creation, NULL);
     qemu_cond_signal(&qemu_cpu_cond);
 
     /* wait for initial kick-off after machine start */