summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorDmitry Frolov <frolov@swemel.ru>2023-08-31 15:59:27 +0300
committerKevin Wolf <kwolf@redhat.com>2023-09-08 17:03:09 +0200
commita8d99c0e6c52191c8a3e01ed79b1a9f186a3a91e (patch)
treef9d4f527811a3ffedd1392c3cb5b0a0e802809f4
parenta675ca4c620e66c1d45d55037f8fc21286af58cd (diff)
downloadfocaccia-qemu-a8d99c0e6c52191c8a3e01ed79b1a9f186a3a91e.tar.gz
focaccia-qemu-a8d99c0e6c52191c8a3e01ed79b1a9f186a3a91e.zip
vmdk: Clean up bdrv_open_child() return value check
bdrv_open_child() may return NULL.
Usually return value is checked for this function.
Check for return value is more reliable.

Fixes: 24bc15d1f6 ("vmdk: Use BdrvChild instead of BDS for references to extents")

Signed-off-by: Dmitry Frolov <frolov@swemel.ru>
Message-ID: <20230831125926.796205-1-frolov@swemel.ru>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
-rw-r--r--block/vmdk.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/block/vmdk.c b/block/vmdk.c
index 70066c2b01..58ce290e9c 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -1207,7 +1207,7 @@ static int vmdk_parse_extents(const char *desc, BlockDriverState *bs,
                                       bs, &child_of_bds, extent_role, false,
                                       &local_err);
         g_free(extent_path);
-        if (local_err) {
+        if (!extent_file) {
             error_propagate(errp, local_err);
             ret = -EINVAL;
             goto out;