diff options
| author | Richard Henderson <richard.henderson@linaro.org> | 2023-07-26 12:58:08 -0700 |
|---|---|---|
| committer | Richard Henderson <richard.henderson@linaro.org> | 2023-07-31 12:19:13 -0700 |
| commit | ad17868eb162a5466d8ad43e5ccb428776403308 (patch) | |
| tree | 0aa1f1fb3bfcdf628be51dc978fc2cf00ed69842 | |
| parent | 79e29851bf57741252a20838cdc59074ab5bac29 (diff) | |
| download | focaccia-qemu-ad17868eb162a5466d8ad43e5ccb428776403308.tar.gz focaccia-qemu-ad17868eb162a5466d8ad43e5ccb428776403308.zip | |
accel/tcg: Clear tcg_ctx->gen_tb on buffer overflow
On overflow of code_gen_buffer, we unlock the guest pages we had been
translating, but failed to clear gen_tb. On restart, if we cannot
allocate a TB, we exit to the main loop to perform the flush of all
TBs as soon as possible. With garbage in gen_tb, we hit an assert:
../src/accel/tcg/tb-maint.c:348:page_unlock__debug: \
assertion failed: (page_is_locked(pd))
Fixes: deba78709ae8 ("accel/tcg: Always lock pages before translation")
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
| -rw-r--r-- | accel/tcg/translate-all.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index a1782db5dd..b2d4e22c17 100644 --- a/accel/tcg/translate-all.c +++ b/accel/tcg/translate-all.c @@ -374,6 +374,7 @@ TranslationBlock *tb_gen_code(CPUState *cpu, "Restarting code generation for " "code_gen_buffer overflow\n"); tb_unlock_pages(tb); + tcg_ctx->gen_tb = NULL; goto buffer_overflow; case -2: |