summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorVladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>2022-06-24 22:52:52 +0300
committerJohn Snow <jsnow@redhat.com>2023-01-24 13:37:12 -0500
commitada73a492cb29b9c3a9f88c5e6d3407fa0d999e7 (patch)
tree646ad9475103fd9c6a407feb81c0fb3011592ec8
parentaf76484e54f6c5e20452c2b329378026b8f2c59d (diff)
downloadfocaccia-qemu-ada73a492cb29b9c3a9f88c5e6d3407fa0d999e7.tar.gz
focaccia-qemu-ada73a492cb29b9c3a9f88c5e6d3407fa0d999e7.zip
python: QEMUMachine: enable qmp accept timeout by default
I've spent much time trying to debug hanging pipeline in gitlab. I
started from and idea that I have problem in code in my series (which
has some timeouts). Finally I found that the problem is that I've used
QEMUMachine class directly to avoid qtest, and didn't add necessary
arguments. Qemu fails and we wait for qmp accept endlessly. In gitlab
it's just stopped by timeout (one hour) with no sign of what's going
wrong.

With timeout enabled, gitlab don't wait for an hour and prints all
needed information.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: John Snow <jsnow@redhat.com>
Message-Id: <20220624195252.175249-1-vsementsov@yandex-team.ru>
[Fixed typing. --js]
Signed-off-by: John Snow <jsnow@redhat.com>
-rw-r--r--python/qemu/machine/machine.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/python/qemu/machine/machine.py b/python/qemu/machine/machine.py
index 748a0d807c..c759db03e4 100644
--- a/python/qemu/machine/machine.py
+++ b/python/qemu/machine/machine.py
@@ -131,7 +131,7 @@ class QEMUMachine:
                  drain_console: bool = False,
                  console_log: Optional[str] = None,
                  log_dir: Optional[str] = None,
-                 qmp_timer: Optional[float] = None):
+                 qmp_timer: Optional[float] = 30):
         '''
         Initialize a QEMUMachine