summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorDavid Gibson <david@gibson.dropbear.id.au>2016-01-21 12:37:51 +1100
committerMichael S. Tsirkin <mst@redhat.com>2016-02-06 20:44:10 +0200
commitadcb4ee660cf579f003e9d4afd61b608259091c6 (patch)
treee3daef631a060a064b01c81cdc9a20e1ef9366e3
parentae12374951f07157f7a52c8d848b90f8eec722fb (diff)
downloadfocaccia-qemu-adcb4ee660cf579f003e9d4afd61b608259091c6.tar.gz
focaccia-qemu-adcb4ee660cf579f003e9d4afd61b608259091c6.zip
dimm: Correct type of MemoryHotplugState->base
The 'base' field of MemoryHotplugState is ram_addr_t, which indicates that
it exists in the abstract address space of RAM regions.

However, the actual usage of this field indicates that it is a concrete
physical address (it's passed as an offset to memory_region_add_subgregion
for example).

So, correct its type to 'hwaddr'.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Acked-by: Eduardo Habkost <ehabkost@redhat.com>
-rw-r--r--include/hw/mem/pc-dimm.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/include/hw/mem/pc-dimm.h b/include/hw/mem/pc-dimm.h
index d83bf30ea9..218dfb0eda 100644
--- a/include/hw/mem/pc-dimm.h
+++ b/include/hw/mem/pc-dimm.h
@@ -77,7 +77,7 @@ typedef struct PCDIMMDeviceClass {
  * @mr: hotplug memory address space container
  */
 typedef struct MemoryHotplugState {
-    ram_addr_t base;
+    hwaddr base;
     MemoryRegion mr;
 } MemoryHotplugState;