diff options
| author | Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> | 2024-06-06 10:53:17 +0100 |
|---|---|---|
| committer | Paolo Bonzini <pbonzini@redhat.com> | 2024-06-08 10:33:38 +0200 |
| commit | aea49fbb01a4a1191165af0b08b5e27994f22c35 (patch) | |
| tree | a935e9b010c82ea30e25edca2f144774808daa20 | |
| parent | f41990f552839ad016467586a9540b9455cc52fd (diff) | |
| download | focaccia-qemu-aea49fbb01a4a1191165af0b08b5e27994f22c35.tar.gz focaccia-qemu-aea49fbb01a4a1191165af0b08b5e27994f22c35.zip | |
target/i386: use gen_writeback() within gen_POP()
Instead of directly implementing the writeback using gen_op_st_v(), use the existing gen_writeback() function. Suggested-by: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> Message-ID: <20240606095319.229650-3-mark.cave-ayland@ilande.co.uk> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
| -rw-r--r-- | target/i386/tcg/emit.c.inc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/target/i386/tcg/emit.c.inc b/target/i386/tcg/emit.c.inc index ca78504b6e..6123235c00 100644 --- a/target/i386/tcg/emit.c.inc +++ b/target/i386/tcg/emit.c.inc @@ -2580,9 +2580,9 @@ static void gen_POP(DisasContext *s, CPUX86State *env, X86DecodedInsn *decode) if (op->has_ea) { /* NOTE: order is important for MMU exceptions */ - gen_op_st_v(s, ot, s->T0, s->A0); - op->unit = X86_OP_SKIP; + gen_writeback(s, decode, 0, s->T0); } + /* NOTE: writing back registers after update is important for pop %sp */ gen_pop_update(s, ot); } |