summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorMarkus Armbruster <armbru@redhat.com>2014-05-28 11:17:07 +0200
committerKevin Wolf <kwolf@redhat.com>2014-05-30 14:26:54 +0200
commitbb9cd2ee99f6537c072d5f4bac441717d3cd2bed (patch)
treeaaa2f9ecd2898b7436543dcbc5c49f6847580e7f
parent2df5fee2dbd56a9c34afd6d7df6744da2d951ccb (diff)
downloadfocaccia-qemu-bb9cd2ee99f6537c072d5f4bac441717d3cd2bed.tar.gz
focaccia-qemu-bb9cd2ee99f6537c072d5f4bac441717d3cd2bed.zip
qemu-img: Plug memory leak in convert command
Introduced in commit 661a0f7.  Spotted by Coverity.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
-rw-r--r--qemu-img.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/qemu-img.c b/qemu-img.c
index 62ea27eae5..d118da5c2f 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -1455,7 +1455,7 @@ static int img_convert(int argc, char **argv)
     ret = bdrv_parse_cache_flags(cache, &flags);
     if (ret < 0) {
         error_report("Invalid cache option: %s", cache);
-        return -1;
+        goto out;
     }
 
     out_bs = bdrv_new_open("target", out_filename, out_fmt, flags, true, quiet);