diff options
| author | Brian Cain <bcain@quicinc.com> | 2024-01-14 15:44:53 -0800 |
|---|---|---|
| committer | Brian Cain <bcain@quicinc.com> | 2024-01-21 22:02:48 -0800 |
| commit | bbe4209c8b4300d722f47791f9151e1a69cb0135 (patch) | |
| tree | d712eb397563cab12946ad085a9678006ec7fd8c | |
| parent | cbb9d7157d3e1886bdc7da757ea7ab02a9e0e1e5 (diff) | |
| download | focaccia-qemu-bbe4209c8b4300d722f47791f9151e1a69cb0135.tar.gz focaccia-qemu-bbe4209c8b4300d722f47791f9151e1a69cb0135.zip | |
target/hexagon: reduce scope of def_regnum, remove dead assignment
This is intended to address a coverity finding: CID 1527408. Signed-off-by: Brian Cain <bcain@quicinc.com> Reviewed-by: Matheus Tavares Bernardino <quic_mathbern@quicinc.com> Message-Id: <20240114234453.4114587-1-bcain@quicinc.com>
| -rw-r--r-- | target/hexagon/mmvec/decode_ext_mmvec.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/target/hexagon/mmvec/decode_ext_mmvec.c b/target/hexagon/mmvec/decode_ext_mmvec.c index 174eb3b78b..202d84c7c0 100644 --- a/target/hexagon/mmvec/decode_ext_mmvec.c +++ b/target/hexagon/mmvec/decode_ext_mmvec.c @@ -33,7 +33,6 @@ check_new_value(Packet *pkt) const char *dststr = NULL; uint16_t def_opcode; char letter; - int def_regnum; for (i = 1; i < pkt->num_insns; i++) { uint16_t use_opcode = pkt->insn[i].opcode; @@ -78,7 +77,6 @@ check_new_value(Packet *pkt) } } if ((dststr == NULL) && GET_ATTRIB(def_opcode, A_CVI_GATHER)) { - def_regnum = 0; pkt->insn[i].regno[use_regidx] = def_oreg; pkt->insn[i].new_value_producer_slot = pkt->insn[def_idx].slot; } else { @@ -86,7 +84,7 @@ check_new_value(Packet *pkt) /* still not there, we have a bad packet */ g_assert_not_reached(); } - def_regnum = pkt->insn[def_idx].regno[dststr - reginfo]; + int def_regnum = pkt->insn[def_idx].regno[dststr - reginfo]; /* Now patch up the consumer with the register number */ pkt->insn[i].regno[use_regidx] = def_regnum ^ def_oreg; /* special case for (Vx,Vy) */ |