diff options
| author | Greg Kurz <gkurz@linux.vnet.ibm.com> | 2015-06-26 09:32:28 +0200 |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2015-07-07 11:21:37 +0300 |
| commit | be1e50a27d5b6845729ae0854f57f3816cf47edb (patch) | |
| tree | 3b543a0e15befd1267d0c35278fb6fe5f8294ed3 | |
| parent | f6e3035f75e5c6a73485335765ae070304c7a110 (diff) | |
| download | focaccia-qemu-be1e50a27d5b6845729ae0854f57f3816cf47edb.tar.gz focaccia-qemu-be1e50a27d5b6845729ae0854f57f3816cf47edb.zip | |
dataplane: fix cross-endian issues
Accesses to vring_avail_event and vring_used_event must honor the queue endianness. This patch allows cross-endian setups to use dataplane (tested with ppc64 on ppc64le, and vice-versa). Suggested-by: Cornelia Huck <cornelia.huck@de.ibm.com> Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
| -rw-r--r-- | hw/virtio/dataplane/vring.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/hw/virtio/dataplane/vring.c b/hw/virtio/dataplane/vring.c index 35891856ee..bed9b11c31 100644 --- a/hw/virtio/dataplane/vring.c +++ b/hw/virtio/dataplane/vring.c @@ -153,7 +153,8 @@ bool vring_should_notify(VirtIODevice *vdev, Vring *vring) return true; } - return vring_need_event(vring_used_event(&vring->vr), new, old); + return vring_need_event(virtio_tswap16(vdev, vring_used_event(&vring->vr)), + new, old); } @@ -407,7 +408,8 @@ int vring_pop(VirtIODevice *vdev, Vring *vring, /* On success, increment avail index. */ vring->last_avail_idx++; if (virtio_has_feature(vdev, VIRTIO_RING_F_EVENT_IDX)) { - vring_avail_event(&vring->vr) = vring->last_avail_idx; + vring_avail_event(&vring->vr) = + virtio_tswap16(vdev, vring->last_avail_idx); } return head; |