summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorDaniel P. Berrangé <berrange@redhat.com>2025-05-30 16:21:18 +0100
committerPhilippe Mathieu-Daudé <philmd@linaro.org>2025-06-10 12:59:09 +0200
commitbebcf2cff4091281ddf67240d5651ed7938ea83a (patch)
tree455eb45d932ac2a3840de7e7c79e8dd1fad4f2af
parenta35391ba87651daeafa02231e842ae28c349cac0 (diff)
downloadfocaccia-qemu-bebcf2cff4091281ddf67240d5651ed7938ea83a.tar.gz
focaccia-qemu-bebcf2cff4091281ddf67240d5651ed7938ea83a.zip
pc-bios: ensure installed ROMs don't have execute permissions
We have been inconsistent about whether ROMS stored in git have
execute permission set, and by default meson will preserve source
file permissions when installing files. This has caused periodic
problems in RPM packaging as executable binary files get analysed
by various tools/linters, which can trip up on the ROMs.

Tell meson explicitly that all the ROMs should be without execute
permission when installed.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Helge Deller <deller@gmx.de>
Tested-by: Helge Deller <deller@gmx.de>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20250530152118.65030-1-berrange@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
-rw-r--r--pc-bios/meson.build2
1 files changed, 1 insertions, 1 deletions
diff --git a/pc-bios/meson.build b/pc-bios/meson.build
index 79bb2e1800..3c41620044 100644
--- a/pc-bios/meson.build
+++ b/pc-bios/meson.build
@@ -88,7 +88,7 @@ blobs = [
 ]
 
 if get_option('install_blobs')
-  install_data(blobs, install_dir: qemu_datadir)
+  install_data(blobs, install_dir: qemu_datadir, install_mode: 'rw-r--r--')
 endif
 
 subdir('descriptors')