summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorMichal Privoznik <mprivozn@redhat.com>2023-06-07 10:01:03 +0200
committerPaolo Bonzini <pbonzini@redhat.com>2023-06-07 11:05:09 +0200
commitc06b1571cc5c27b2042315b2a1c99f477a497716 (patch)
tree6f5f95e44667fefe122377702124d03062d0619d
parente58e55dd8d5777f8a58ce30cfe04a8023282eb80 (diff)
downloadfocaccia-qemu-c06b1571cc5c27b2042315b2a1c99f477a497716.tar.gz
focaccia-qemu-c06b1571cc5c27b2042315b2a1c99f477a497716.zip
configure: check for $download value properly
If configure was invoked with --disable-download and git
submodules were not checked out a warning is produced and the
configure script fails. But the $download variable (which
reflects the enable/disable download argument) is checked for in
a weird fashion:

  test -f "$download" = disabled

Drop the '-f' to check for the actual value of the variable.

Fixes: 2019cabfee0 ("meson: subprojects: replace submodules with wrap files", 2023-06-06)
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
-rwxr-xr-xconfigure2
1 files changed, 1 insertions, 1 deletions
diff --git a/configure b/configure
index 8765b88e12..8a638dd82a 100755
--- a/configure
+++ b/configure
@@ -767,7 +767,7 @@ if test "$plugins" = "yes" -a "$tcg" = "disabled"; then
 fi
 
 if ! test -f "$source_path/subprojects/keycodemapdb/README" \
-    && test -f "$download" = disabled
+    && test "$download" = disabled
 then
     echo
     echo "ERROR: missing subprojects"