diff options
| author | Philippe Mathieu-Daudé <philmd@redhat.com> | 2021-07-27 16:24:31 +0200 |
|---|---|---|
| committer | Thomas Huth <thuth@redhat.com> | 2021-07-29 07:56:01 +0200 |
| commit | c217fd8e36a1d619956f550e8a39528a855de2f5 (patch) | |
| tree | f42387d69b85b2d33f6862cfe06493c577f74f3b | |
| parent | 59e8b62b22062e8849429bf1e9cfde6f0affb83c (diff) | |
| download | focaccia-qemu-c217fd8e36a1d619956f550e8a39528a855de2f5.tar.gz focaccia-qemu-c217fd8e36a1d619956f550e8a39528a855de2f5.zip | |
gitlab-ci: Fix 'when:' condition in OpenSBI jobs
Jobs depending on another should not use the 'when: always'
condition, because if a dependency failed we should not keep
running jobs depending on it. The correct condition is
'when: on_success'.
Fixes: c6fc0fc1a71 ("gitlab-ci.yml: Add jobs to build OpenSBI firmware binaries")
Reported-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Message-Id: <20210727142431.1672530-5-philmd@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
| -rw-r--r-- | .gitlab-ci.d/opensbi.yml | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/.gitlab-ci.d/opensbi.yml b/.gitlab-ci.d/opensbi.yml index d8a0456679..5e0a2477c5 100644 --- a/.gitlab-ci.d/opensbi.yml +++ b/.gitlab-ci.d/opensbi.yml @@ -6,14 +6,14 @@ - .gitlab-ci.d/opensbi.yml # or the Dockerfile is modified - .gitlab-ci.d/opensbi/Dockerfile - when: always + when: on_success - changes: # or roms/opensbi/ is modified (submodule updated) - roms/opensbi/* - when: always + when: on_success - if: '$CI_COMMIT_REF_NAME =~ /^opensbi/' # or the branch/tag starts with 'opensbi' - when: always + when: on_success - if: '$CI_COMMIT_MESSAGE =~ /opensbi/i' # or last commit description contains 'OpenSBI' - when: always + when: on_success docker-opensbi: extends: .opensbi_job_rules |