summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorLuiz Capitulino <lcapitulino@redhat.com>2011-10-13 11:36:40 -0300
committerLuiz Capitulino <lcapitulino@redhat.com>2011-10-19 10:48:57 -0200
commitc370f09dba0f0d92e0e8127e9e444f58e9332448 (patch)
treed66f6818de3594e981fd75949f6b072705600a98
parentee21cb5f1db20ae449d2b59130fd6b7bdc8a6e4b (diff)
downloadfocaccia-qemu-c370f09dba0f0d92e0e8127e9e444f58e9332448.tar.gz
focaccia-qemu-c370f09dba0f0d92e0e8127e9e444f58e9332448.zip
savevm: qemu_savevm_state(): Drop stop VM logic
qemu_savevm_state() has some logic to stop the VM and to (or not to)
resume it. But this seems to be a big noop, as qemu_savevm_state()
is only called by do_savevm() when the VM is already stopped.

So, let's drop qemu_savevm_state()'s stop VM logic.

Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
-rw-r--r--savevm.c7
1 files changed, 0 insertions, 7 deletions
diff --git a/savevm.c b/savevm.c
index bf4d0e76c3..abb4a60643 100644
--- a/savevm.c
+++ b/savevm.c
@@ -1599,12 +1599,8 @@ void qemu_savevm_state_cancel(Monitor *mon, QEMUFile *f)
 
 static int qemu_savevm_state(Monitor *mon, QEMUFile *f)
 {
-    int saved_vm_running;
     int ret;
 
-    saved_vm_running = runstate_is_running();
-    vm_stop(RUN_STATE_SAVE_VM);
-
     if (qemu_savevm_state_blocked(mon)) {
         ret = -EINVAL;
         goto out;
@@ -1626,9 +1622,6 @@ out:
     if (qemu_file_has_error(f))
         ret = -EIO;
 
-    if (!ret && saved_vm_running)
-        vm_start();
-
     return ret;
 }