summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorJens Remus <jremus@linux.ibm.com>2024-10-01 17:36:16 +0200
committerThomas Huth <thuth@redhat.com>2024-10-23 06:53:44 +0200
commitc58df213af7ec8924d219025a593b8f3ac475f16 (patch)
treedd39fdfa82a69e7238b38457136035a16b76b1d6
parentf5aa2d9d4c6480fa73b89c935050afe57e5d8bd9 (diff)
downloadfocaccia-qemu-c58df213af7ec8924d219025a593b8f3ac475f16.tar.gz
focaccia-qemu-c58df213af7ec8924d219025a593b8f3ac475f16.zip
pc-bios/s390-ccw: Clarify alignment is in bytes
The assembler directive .align [1] has architecture-dependent behavior,
which may be ambiguous for the reader. Some architectures perform the
alignment in bytes, others in power of two. s390 does in bytes.

Use the directive .balign [2] instead, to clarify that the alignment
request is in bytes. No functional change.

[1] https://sourceware.org/binutils/docs/as/Align.html
[2] https://sourceware.org/binutils/docs/as/Balign.html

Signed-off-by: Jens Remus <jremus@linux.ibm.com>
Reviewed-by: Marc Hartmayer <mhartmay@linux.ibm.com>
Message-ID: <20241001153618.17791-2-mhartmay@linux.ibm.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
-rw-r--r--pc-bios/s390-ccw/start.S4
1 files changed, 2 insertions, 2 deletions
diff --git a/pc-bios/s390-ccw/start.S b/pc-bios/s390-ccw/start.S
index 061b06591c..576fc12c06 100644
--- a/pc-bios/s390-ccw/start.S
+++ b/pc-bios/s390-ccw/start.S
@@ -112,7 +112,7 @@ io_new_code:
     lctlg   %c6,%c6,0(%r15)
     br      %r14
 
-    .align  8
+    .balign 8
 bss_start_literal:
     .quad   __bss_start
 disabled_wait_psw:
@@ -125,7 +125,7 @@ io_new_mask:
     .quad   0x0000000180000000
 
 .bss
-    .align  8
+    .balign 8
 stack:
     .space  STACK_SIZE
     .size   stack,STACK_SIZE